Messages in this thread | | | Date | Mon, 26 Sep 2016 12:03:29 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH -v2 3/9] sched/deadline/rtmutex: Dont miss the dl_runtime/dl_period update |
| |
On Mon, 26 Sep 2016 14:32:16 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> Currently dl tasks will actually return at the very beginning > of rt_mutex_adjust_prio_chain() in !detect_deadlock cases: > > if (waiter->prio == task->prio) { > if (!detect_deadlock) > goto out_unlock_pi; // out here > else > requeue = false; > } > > As the deadline value of blocked deadline tasks(waiters) without > changing their sched_class(thus prio doesn't change) never changes, > this seems reasonable, but it actually misses the chance of updating > rt_mutex_waiter's "dl_runtime(period)_copy" if a waiter updates its > deadline parameters(dl_runtime, dl_period) or boosted waiter changes > to !deadline class. > > Thus, force deadline task not out by adding the !dl_prio() condition. > > Cc: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org.
-- Steve
> Cc: Ingo Molnar <mingo@redhat.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Juri Lelli <juri.lelli@arm.com> > Signed-off-by: Xunlei Pang <xlpang@redhat.com> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Link: http://lkml.kernel.org/r/1460633827-345-7-git-send-email-xlpang@redhat.com
| |