lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error
Hi all,

On Sun, 25 Sep 2016 20:06:19 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> exactly like you did. It's just that with 12 characters in the hex
> format, people will still be able to cut-and-paste the hash into git
> to get the full commit details even a year from now. With just 7 hex
> digits, you may well end up in the situation where you do
>
> git show e23d415
>
> and git says
>
> error: short SHA1 e23d415 is ambiguous.
> fatal: ambiguous argument 'e23d415': unknown revision or path not
> in the working tree.
>
> (it's not ambiguous today, but in a year or two it quite possibly will be).

I have already had over the years a few instances of 7 digit commit
hashes that are unique in Linus' tree but not in mine (which is a bit
of a pain if you are trying to look for context).

--
Cheers,
Stephen Rothwell

\
 
 \ /
  Last update: 2016-09-26 13:25    [W:0.093 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site