lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock
    From
    Date
    Hi,

    On 23/09/16 21:47, Rob Herring wrote:
    > On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote:
    >> This binding allow to disable the internal 60Mhz clock for USB host2 or
    >> host3.
    >>
    >> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
    >> ---
    >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
    >> drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++
    >> drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
    >> drivers/usb/chipidea/usbmisc_imx.c | 13 +++++++++++++
    >> 4 files changed, 17 insertions(+)
    >>
    >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
    >> index 0e03344..f83da66 100644
    >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
    >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
    >> @@ -84,6 +84,7 @@ i.mx specific properties
    >> - over-current-active-high: over current signal polarity is high active,
    >> typically over current signal polarity is low active.
    >> - external-vbus-divider: enables off-chip resistor divider for Vbus
    >> +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53
    >
    > Doesn't this depend on something else like the type of phy connected? If
    > not, when can you do this or not?
    >

    We can disable it in OTG mode and with ULPI phy and Sascha Hauer think
    we can do it without dt binding for example based on PHY mode. So I will
    remove the binding and just disable clock if ULPI is selected.

    > Rob
    >

    Fabien

    \
     
     \ /
      Last update: 2016-09-26 11:01    [W:4.047 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site