lkml.org 
[lkml]   [2016]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: android: fixed permissions style issue
From
Date
On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote:
> Fixed a coding style issue. Changed symbolic permissions to octal.

If you do these, please shorten the lines where possible.

> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
> * not really modular, but the easiest way to keep compat with existing
> * bootargs behaviour is to continue using module_param here.
> */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> - S_IRUGO | S_IWUSR);
> + 0644);

module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644);

etc...

\
 
 \ /
  Last update: 2016-09-26 05:00    [W:0.039 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site