lkml.org 
[lkml]   [2016]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drm/i2c: tda998x: don't register the connector
    On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote:
    > On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote:
    > > Hm, maybe we should simply not call ->lastclose for kms drivers. That is
    > > kinda only a hack for ums/dri1 drivers.
    >
    > Are you sure about that - isn't it needed so that the fbdev mode gets
    > restored when the last DRM user exits, so that the VT consoles becomes
    > functional again?
    >
    > I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked()
    > in Armada's ->lastclose to ensure that VT consoles worked after Xorg was
    > shutdown.

    I meant not call it on driver unload. When closing the last drm fd we
    indeed need it to restore the fbdev vt. That use-case definitely needs to
    stay for kms drivers.
    -Daniel
    --
    Daniel Vetter
    Software Engineer, Intel Corporation
    http://blog.ffwll.ch

    \
     
     \ /
      Last update: 2016-09-25 22:35    [W:2.169 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site