lkml.org 
[lkml]   [2016]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 23 Sep 2016 22:30:32 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/iio/industrialio-buffer.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
    index 49bf9c5..7a4d9499 100644
    --- a/drivers/iio/industrialio-buffer.c
    +++ b/drivers/iio/industrialio-buffer.c
    @@ -307,10 +307,9 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev,
    const unsigned long *mask;
    unsigned long *trialmask;

    - trialmask = kmalloc(sizeof(*trialmask)*
    - BITS_TO_LONGS(indio_dev->masklength),
    - GFP_KERNEL);
    -
    + trialmask = kmalloc_array(BITS_TO_LONGS(indio_dev->masklength),
    + sizeof(*trialmask),
    + GFP_KERNEL);
    if (trialmask == NULL)
    return -ENOMEM;
    if (!indio_dev->masklength) {
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-24 08:25    [W:4.020 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site