lkml.org 
[lkml]   [2016]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()
On Sat, Sep 24, 2016 at 06:32:29PM +0200, SF Markus Elfring wrote:
> >> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
> >>> unsigned long flags;
> >>> unsigned char u;
> >>
> >>> - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
> >>> - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
> >>> - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
> >>> + pr_info(",------------------ START ----------------.\n"
> >>> + "| Dumping: %30s |\n"
> >>> + "| Speed: %28d kHz |\n",
> >>> + gameport->phys,
> >>> + gameport->speed);
> >
> > Not the same output.
>
> Should the desired output be the same when the relevant data are passed by a single function call
> (instead of three as before)?

The desired output should not be broken in conversion, which you did. Do
you know how syslog works and why the transformation is not correct.

I am also curious as to why you are patching joydump? Are you working on
extending it?

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2016-09-24 18:39    [W:0.108 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site