lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] staging: ion: Fix a coding style issue
From
Date
On 09/23/2016 11:03 AM, Antti Keränen wrote:
> This patch fixes the alignment of an allocation flag block comment
> and moves the comments before each #define.
>

Acked-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> In addition to fixing the alignment issue, this version of the patch moves
> the comments from after the define lines to before the define lines.
>
> drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..14cd873 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -52,18 +52,18 @@ enum ion_heap_type {
> * allocation flags - the lower 16 bits are used by core ion, the upper 16
> * bits are reserved for use by the heaps themselves.
> */
> -#define ION_FLAG_CACHED 1 /*
> - * mappings of this buffer should be
> - * cached, ion will do cache
> - * maintenance when the buffer is
> - * mapped for dma
> - */
> -#define ION_FLAG_CACHED_NEEDS_SYNC 2 /*
> - * mappings of this buffer will created
> - * at mmap time, if this is set
> - * caches must be managed
> - * manually
> - */
> +
> +/*
> + * mappings of this buffer should be cached, ion will do cache maintenance
> + * when the buffer is mapped for dma
> + */
> +#define ION_FLAG_CACHED 1
> +
> +/*
> + * mappings of this buffer will created at mmap time, if this is set
> + * caches must be managed manually
> + */
> +#define ION_FLAG_CACHED_NEEDS_SYNC 2
>
> /**
> * DOC: Ion Userspace API
>

\
 
 \ /
  Last update: 2016-09-23 22:37    [W:0.048 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site