Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser | Date | Fri, 23 Sep 2016 19:20:31 +0100 |
| |
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> > case RXRPC_ACK_TYPE_NACK: > > if (anno_type == RXRPC_TX_ANNO_NAK) > > continue; > > + if (anno_type == RXRPC_TX_ANNO_RETRANS) > > + continue; > > Why not fold the above 2 *if*s together? Or use *else if* at least?
I have a pending patch that adds something between them.
David
| |