lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser
    Date
    Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

    > > case RXRPC_ACK_TYPE_NACK:
    > > if (anno_type == RXRPC_TX_ANNO_NAK)
    > > continue;
    > > + if (anno_type == RXRPC_TX_ANNO_RETRANS)
    > > + continue;
    >
    > Why not fold the above 2 *if*s together? Or use *else if* at least?

    I have a pending patch that adds something between them.

    David

    \
     
     \ /
      Last update: 2016-09-23 20:21    [W:2.425 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site