lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case.
On Fri, 23 Sep 2016, Arvind Yadav wrote:

So last time (V2) you had a almost perfect subject line:

clocksrouce/timer-imz-gpt: Prevent resource leaks in error path

The only issue was the clocksrcouce typo. Now you made it:

clocksource/timer-imx-gpt: Preventing resource leakage in error case.

Documentation/SubmittingPatches says:

Describe your changes in imperative mood ... as if you are giving orders
to the codebase to change its behaviour.

"Preventing" is not imperative and the above is not a proper sentence,
while the V2 one is.

> ret = _mxc_timer_init(imxtm);
> - if (ret)
> - return ret;
> + if (ret) {
> + goto error_iounmap;
> + }

Further Documentation/SubmittingPatches also tells you which tools to use
_before_ submission. If you'd used them then the above change would look
different. You surely can figure that out yourself.

Thanks,

tglx


\
 
 \ /
  Last update: 2016-09-23 18:44    [W:0.117 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site