lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 03/16] perf script: Fix vanished idle symbols
Date
Patch "perf symbols: Mark if a symbol is idle in the library" causes idle
symbols to vanish from perf script output. That is because print functions
suppress symbols marked as 'idle'. However, suppression of 'idle' functions
is only used by 'perf top' and 'perf top' does not use the print functions.
Consequently that functionality can simply be removed from the print
functions.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/evsel_fprintf.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index 9111e0666950..662a0a6182e7 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools/perf/util/evsel_fprintf.c
@@ -122,9 +122,6 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
if (!node)
break;

- if (node->sym && node->sym->idle)
- goto next;
-
printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");

if (print_ip)
@@ -158,7 +155,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,

if (!print_oneline)
printed += fprintf(fp, "\n");
-next:
+
callchain_cursor_advance(cursor);
}
}
@@ -181,7 +178,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,
if (cursor != NULL) {
printed += sample__fprintf_callchain(sample, left_alignment,
print_opts, cursor, fp);
- } else if (!(al->sym && al->sym->idle)) {
+ } else {
printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");

if (print_ip)
--
1.9.1
\
 
 \ /
  Last update: 2016-09-23 16:47    [W:0.191 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site