lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf hists: Add __hist_entry__snprintf function
    Commit-ID:  9da44db1493a9d384ddc1bcd1553a1803ff985b6
    Gitweb: http://git.kernel.org/tip/9da44db1493a9d384ddc1bcd1553a1803ff985b6
    Author: Jiri Olsa <jolsa@kernel.org>
    AuthorDate: Thu, 22 Sep 2016 17:36:29 +0200
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 22 Sep 2016 13:08:56 -0300

    perf hists: Add __hist_entry__snprintf function

    Add __hist_entry__snprintf() to take a perf_hpp_list as an argument
    instead of using he->hists->hpp_list.

    This way we can display arbitrary list of entries regardless of the
    hists setup, which will be useful in the upcoming c2c patch series.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Don Zickus <dzickus@redhat.com>
    Cc: Joe Mario <jmario@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1474558645-19956-2-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/ui/stdio/hist.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
    index c8dca34..189665c 100644
    --- a/tools/perf/ui/stdio/hist.c
    +++ b/tools/perf/ui/stdio/hist.c
    @@ -373,7 +373,8 @@ static size_t hist_entry_callchain__fprintf(struct hist_entry *he,
    return 0;
    }

    -static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    +static int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
    + struct perf_hpp_list *hpp_list)
    {
    const char *sep = symbol_conf.field_sep;
    struct perf_hpp_fmt *fmt;
    @@ -384,7 +385,7 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    if (symbol_conf.exclude_other && !he->parent)
    return 0;

    - hists__for_each_format(he->hists, fmt) {
    + perf_hpp_list__for_each_format(hpp_list, fmt) {
    if (perf_hpp__should_skip(fmt, he->hists))
    continue;

    @@ -410,6 +411,11 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    return hpp->buf - start;
    }

    +static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    +{
    + return __hist_entry__snprintf(he, hpp, he->hists->hpp_list);
    +}
    +
    static int hist_entry__hierarchy_fprintf(struct hist_entry *he,
    struct perf_hpp *hpp,
    struct hists *hists,
    \
     
     \ /
      Last update: 2016-09-23 07:29    [W:4.390 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site