Messages in this thread | | | Subject | Re: [PATCH] drivers: wlan-ng: fixed a coding style issue | From | Joe Perches <> | Date | Thu, 22 Sep 2016 11:27:00 -0700 |
| |
On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote: > changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding > style.
Hello.
Please always use Greg KH's latest staging-next branch (or -next) to make these sorts of changes. This one has already been done.
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/ $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git $ cd staging $ git checkout staging-next
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c [] > @@ -305,7 +305,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev, > > memset(sinfo, 0, sizeof(*sinfo)); > > - if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING)) > + if ((!wlandev) || (wlandev->msdstate != WLAN_MSD_RUNNING))
And it might be nicer without the unnecessary parentheses too
if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
| |