Messages in this thread | | | Subject | Re: [PATCH v2 3/4] mmc: dw_mmc: fix misleading error print if failing to do DMA transfer | From | Jaehoon Chung <> | Date | Thu, 22 Sep 2016 13:26:45 +0900 |
| |
On 09/02/2016 01:14 PM, Shawn Lin wrote: > The original log didn't figure out that we could still > finish this transfer by PIO mode even if failing to use > DMA. And it should be kept for debug level instead of > error one.
Applied on my tree. Thanks!
Best Regards, Jaehoon Chung
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index daa1c52..833b6ad 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1057,8 +1057,10 @@ static int dw_mci_submit_data_dma(struct dw_mci *host, struct mmc_data *data) > spin_unlock_irqrestore(&host->irq_lock, irqflags); > > if (host->dma_ops->start(host, sg_len)) { > - /* We can't do DMA */ > - dev_err(host->dev, "%s: failed to start DMA.\n", __func__); > + /* We can't do DMA, try PIO for this one */ > + dev_dbg(host->dev, > + "%s: fall back to PIO mode for current transfer\n", > + __func__); > return -ENODEV; > } > >
| |