Messages in this thread | | | Subject | Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support | From | Peter Ujfalusi <> | Date | Thu, 22 Sep 2016 14:16:42 +0300 |
| |
On 09/22/16 13:45, Mugunthan V N wrote: >>> + if (!dma->chan) >>> + return -ENODEV; >>> + >>> + /* RX buffer */ >>> + dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE, >>> + &dma->addr, GFP_KERNEL); >>> + if (!dma->buf) >>> + goto err; >>> + >>> + dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n"); >> >> Do we need _ratelimited? AFAICS, this print is called only once. > > True, will change to dev_dbg.
It would be better to remove it. It gives no useful debuggin information apart from the fact that the driver did not failed to probe.
-- Péter
| |