lkml.org 
[lkml]   [2016]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipmi: Fix ioremap error handling in bt-bmc
From
Date
On 09/21/2016 05:17 AM, Cédric Le Goater wrote:
> On 09/21/2016 12:05 PM, Joel Stanley wrote:
>> devm_ioremap_resource returns ERR_PTR so we can't check for NULL.
> Thanks for spotting this.
>
> Acked-by: Cédric Le Goater <clg@kaod.org>

Thanks, I've pull this into my tree.

-corey

> C.
>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> drivers/char/ipmi/bt-bmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
>> index 2e880bf0be26..de64bf1f2f4d 100644
>> --- a/drivers/char/ipmi/bt-bmc.c
>> +++ b/drivers/char/ipmi/bt-bmc.c
>> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
>> }
>>
>> bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
>> - if (!bt_bmc->base)
>> - return -ENOMEM;
>> + if (IS_ERR(bt_bmc->base))
>> + return PTR_ERR(bt_bmc->base);
>>
>> mutex_init(&bt_bmc->mutex);
>> init_waitqueue_head(&bt_bmc->queue);
>>

\
 
 \ /
  Last update: 2016-09-22 23:59    [W:0.035 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site