lkml.org 
[lkml]   [2016]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks
On Tue, Sep 20, 2016 at 11:39:35PM -0700, Andy Lutomirski wrote:
> > And the ia64 entry code has some similar language:
> >
> > /*
> > * Invoke schedule_tail(task) while preserving in0-in7, which may be needed
> > * in case a system call gets restarted.
> > */
> > GLOBAL_ENTRY(ia64_invoke_schedule_tail)
> > ...
>
> That comment has to be wrong. What syscall could possibly be
> restarted across schedule_tail()? It's a brand new thread and has
> literally never done a syscall.

Hm, yeah, that comment doesn't make any sense.

> There may be another reason that the registers are live there, but I
> generally do my best to never look at ia64 asm code.

Yeah, I'm just going to turn around, pretend I never saw it, and slowly
walk away...

--
Josh

\
 
 \ /
  Last update: 2016-09-22 23:59    [W:0.080 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site