Messages in this thread | | | Subject | Re: [PATCH v5 1/6] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request | From | Vlastimil Babka <> | Date | Wed, 21 Sep 2016 11:06:39 +0200 |
| |
On 08/29/2016 07:07 AM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Freepage on ZONE_HIGHMEM doesn't work for kernel memory so it's not that > important to reserve. When ZONE_MOVABLE is used, this problem would > theorectically cause to decrease usable memory for GFP_HIGHUSER_MOVABLE > allocation request which is mainly used for page cache and anon page > allocation. So, fix it. > > And, defining sysctl_lowmem_reserve_ratio array by MAX_NR_ZONES - 1 size > makes code complex. For example, if there is highmem system, following > reserve ratio is activated for *NORMAL ZONE* which would be easyily > misleading people. > > #ifdef CONFIG_HIGHMEM > 32 > #endif > > This patch also fix this situation by defining sysctl_lowmem_reserve_ratio > array by MAX_NR_ZONES and place "#ifdef" to right place. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
| |