lkml.org 
[lkml]   [2016]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] x86/entry/head/32: use local labels
On Tue, Sep 20, 2016 at 05:57:16PM -0700, Andy Lutomirski wrote:
> On Sep 20, 2016 10:03 AM, "Josh Poimboeuf" <jpoimboe@redhat.com> wrote:
> >
> > Add the local label prefix to all non-function named labels in head_32.S
> > and entry_32.S. In addition to decluttering the symbol table, it also
> > will help stack traces to be more sensible. For example, the last
> > reported function in the idle task stack trace will be startup_32_smp()
> > instead of is486().
> >
>
> I think that restore_all, at least, should stay. It's a common tail
> for lots of functions. I haven't checked this patch for other cases
> where the new label is worse than the old for debugging.

Yes, for restore_all, I think you're right. I'll change it back.

--
Josh

\
 
 \ /
  Last update: 2016-09-21 04:52    [W:0.118 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site