Messages in this thread | | | From | Sumit Semwal <> | Date | Tue, 20 Sep 2016 18:23:33 +0530 | Subject | Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static |
| |
Hi Baoyou,
On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote: > 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>: > >> We get 1 warning when building kernel with W=1: >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is >> declared and don't need a declaration, but can be made static. >> So this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> >> --- >> drivers/dma-buf/sw_sync.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for finding this.
Thanks for the patch; this doesn't apply to mainline yet, since the de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. CC'ing him.
Greg, would it be possible to please take this via your tree? > > Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
> Gustavo >
Best regards, Sumi
| |