Messages in this thread | | | Date | Fri, 2 Sep 2016 16:45:31 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: move struct tpm_class_ops to drivers/char/tpm/tpm.h |
| |
On Sat, Sep 03, 2016 at 01:35:22AM +0300, Jarkko Sakkinen wrote: > On Fri, Sep 02, 2016 at 04:11:22PM -0600, Jason Gunthorpe wrote: > > On Sat, Sep 03, 2016 at 12:48:03AM +0300, Jarkko Sakkinen wrote: > > > The struct tpm_class_ops is not used outside the TPM driver. Thus, > > > it can be safely move to drivers/char/tpm/tpm.h. > > > > No, this is the wrong direction. > > > > The goal is to make things more like other subsystems, so we should be > > moving struct tpm_chip into the public header, and that requires ops > > to be in the public header. > > > > This is why I put ops here in the first place. > > I'm OK with it as long as you explain why this is necessary. I see no > use for them outside the TPM subsystem.
That is because the users out side the subsystem are Doing it Wrong.
eg this:
extern int tpm_is_tpm2(u32 chip_num);
Should be:
extern int tpm_is_tpm2(struct tpm_chip *chip);
And same for all other examples.
The 'chip_num' thing is bonkers.
Jason
| |