Messages in this thread | | | Date | Mon, 19 Sep 2016 21:56:33 -0400 (EDT) | Subject | Re: [PATCH] net: hns: mark symbols static where possible | From | David Miller <> |
| |
From: Baoyou Xie <baoyou.xie@linaro.org> Date: Sun, 18 Sep 2016 17:07:25 +0800
> We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Does not apply cleanly to net-next, please respin.
| |