lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: gpio_charger: switch to using GPIO descriptors
Hi Linus,

On Fri, Sep 09, 2016 at 01:40:04PM +0200, Linus Walleij wrote:
> The GPIO charger is using a mix of the legacy GPIO interface
> and <linux/of_gpio.h> which is not the modern way to use GPIOs.
>
> Refactor like this:
>
> - Use a GPIO descriptor for the GPIO line used to monitor the
> charger.
> - Fetch the descriptor with devm_gpiod_get() as the first
> method.
> - If this fails and we are *not* using device tree, then
> start looking to see if we can use platform data instead.
> - After looking up and requesting a GPIO number with the
> legacy API, convert it to a descriptor.
>
> This way we can later isolate and drop the legacy code as
> more platforms move over to using descriptors.
>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I would be very happy if some people can test this. I think
> only the chromebook use it from device tree, but I'm equally
> interested in the legacy usecase to work as nice as before.

Since this is not tested on any hardware and we're already
at rc7, I would prefer to take this after the merge window.
Any reason this should go into v4.9?

> drivers/power/gpio-charger.c | 84 ++++++++++++++++++++++++++------------------
> 1 file changed, 50 insertions(+), 34 deletions(-)

This is obviously not based on power-supply's next branch, since
I moved all drivers to drivers/power/supply.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-19 21:19    [W:0.055 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site