lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 4/5] GPU-DRM: Replace a kzalloc() call by kcalloc() in drm_legacy_addbufs_sg()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 19 Sep 2016 17:30:31 +0200

    The script "checkpatch.pl" can point information out like the following.

    WARNING: Prefer kcalloc over kzalloc with multiply

    Thus fix the affected source code place.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/drm_bufs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
    index 36dd685..adb1dd7 100644
    --- a/drivers/gpu/drm/drm_bufs.c
    +++ b/drivers/gpu/drm/drm_bufs.c
    @@ -1117,8 +1117,7 @@ static int drm_legacy_addbufs_sg(struct drm_device *dev,
    return -EINVAL;
    }

    - entry->buflist = kzalloc(count * sizeof(*entry->buflist),
    - GFP_KERNEL);
    + entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);
    if (!entry->buflist) {
    mutex_unlock(&dev->struct_mutex);
    atomic_dec(&dev->buf_alloc);
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-19 17:57    [W:4.026 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site