lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/5] GPU-DRM: Use kmalloc_array() in drm_legacy_addbufs_pci()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 19 Sep 2016 17:07:06 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/drm_bufs.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
    index 3219151..ed33f43 100644
    --- a/drivers/gpu/drm/drm_bufs.c
    +++ b/drivers/gpu/drm/drm_bufs.c
    @@ -923,8 +923,9 @@ int drm_legacy_addbufs_pci(struct drm_device *dev,
    /* Keep the original pagelist until we know all the allocations
    * have succeeded
    */
    - temp_pagelist = kmalloc((dma->page_count + (count << page_order)) *
    - sizeof(*dma->pagelist), GFP_KERNEL);
    + temp_pagelist = kmalloc_array(dma->page_count + (count << page_order),
    + sizeof(*dma->pagelist),
    + GFP_KERNEL);
    if (!temp_pagelist) {
    kfree(entry->buflist);
    kfree(entry->seglist);
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-19 17:55    [W:4.063 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site