lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/6] kvm: x86: drop read_tsc_offset()
    From
    Date


    On 19/09/2016 17:30, Jim Mattson wrote:
    > vmx_read_tsc_offset has a bug when running nested VMs. It should really be:
    >
    > if (is_guest_mode(vcpu))
    > return to_vmx(vcpu)->nested.vmcs01_tsc_offset;
    > else
    > return vmcs_read64(TSC_OFFSET);
    >
    > Perhaps a better name woulf be "vmx_get_l1_tsc_offset."

    I agree, but doesn't this patch fix the bug too?

    Paolo

    > In any case, this does not seem consistent with vcpu->arch.tsc_offset.

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-09-19 17:35    [W:4.030 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site