lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/61] perf tools: Make hist_entry__snprintf work over struct perf_hpp_list
    Date
    Make hist_entry__snprintf to take perf_hpp_list as an argument
    instead of using he->hists->hpp_list. This way we can display
    arbitrary list of entries regardles of the hists setup, which
    will be useful in following patches.

    Link: http://lkml.kernel.org/n/tip-j2sizkyglam3narmndlj99xq@git.kernel.org
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    tools/perf/ui/stdio/hist.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
    index a57131e61fe3..cb0371106c21 100644
    --- a/tools/perf/ui/stdio/hist.c
    +++ b/tools/perf/ui/stdio/hist.c
    @@ -373,7 +373,8 @@ static size_t hist_entry_callchain__fprintf(struct hist_entry *he,
    return 0;
    }

    -static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    +static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
    + struct perf_hpp_list *hpp_list)
    {
    const char *sep = symbol_conf.field_sep;
    struct perf_hpp_fmt *fmt;
    @@ -384,7 +385,7 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
    if (symbol_conf.exclude_other && !he->parent)
    return 0;

    - hists__for_each_format(he->hists, fmt) {
    + perf_hpp_list__for_each_format(hpp_list, fmt) {
    if (perf_hpp__should_skip(fmt, he->hists))
    continue;

    @@ -509,7 +510,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
    if (symbol_conf.report_hierarchy)
    return hist_entry__hierarchy_fprintf(he, &hpp, hists, fp);

    - hist_entry__snprintf(he, &hpp);
    + hist_entry__snprintf(he, &hpp, hists->hpp_list);

    ret = fprintf(fp, "%s\n", bf);

    --
    2.7.4
    \
     
     \ /
      Last update: 2016-09-19 15:11    [W:4.230 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site