Messages in this thread | | | Subject | Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h | From | Christian König <> | Date | Mon, 19 Sep 2016 12:03:31 +0200 |
| |
Am 18.09.2016 um 16:29 schrieb Baoyou Xie: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype for 'init_cond_exec' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype for 'patch_cond_exec' [-Wmissing-prototypes] > > In fact, both functions are not declared in any files. > > So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
NAK, IIRC Alex posted a patch last week to remove those two.
Regards, Christian.
> --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index 8e3d9b2..7b71cbe 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct fence **fence); > void amdgpu_fence_process(struct amdgpu_ring *ring); > int amdgpu_fence_wait_empty(struct amdgpu_ring *ring); > unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring); > +unsigned int init_cond_exec(struct amdgpu_ring *ring); > +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset); > > /* > * BO.
| |