lkml.org 
[lkml]   [2016]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy
    On Tue, Sep 13, 2016 at 04:45:51PM +0900, Namhyung Kim wrote:
    > When --hierarchy option is used, each entry has its own hpp_list to show
    > the result. But it missed to update width of each column.
    >
    > Fixes: 1b2dbbf41a0f ("perf hists: Use own hpp_list for hierarchy mode")
    > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    > ---
    > tools/perf/ui/browsers/hists.c | 6 ++++++
    > 1 file changed, 6 insertions(+)
    >
    > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
    > index 35e44b1879e3..49db16334814 100644
    > --- a/tools/perf/ui/browsers/hists.c
    > +++ b/tools/perf/ui/browsers/hists.c
    > @@ -2067,6 +2067,7 @@ void hist_browser__init(struct hist_browser *browser,
    > struct hists *hists)
    > {
    > struct perf_hpp_fmt *fmt;
    > + struct perf_hpp_list_node *node;
    >
    > browser->hists = hists;
    > browser->b.refresh = hist_browser__refresh;
    > @@ -2079,6 +2080,11 @@ void hist_browser__init(struct hist_browser *browser,
    > perf_hpp__reset_width(fmt, hists);
    > ++browser->b.columns;
    > }
    > + /* hierarchy entries have their own hpp list */
    > + list_for_each_entry(node, &hists->hpp_formats, list) {
    > + perf_hpp_list__for_each_format(&node->hpp, fmt)
    > + perf_hpp__reset_width(fmt, hists);
    > + }

    we could add new function hists__reset_width and use it from
    both std and tui code

    thanks,
    jirka

    \
     
     \ /
      Last update: 2016-09-19 10:05    [W:4.555 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site