lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt
2016-09-15 16:58 GMT+08:00 Thomas Gleixner <tglx@linutronix.de>:
> On Thu, 15 Sep 2016, Wanpeng Li wrote:
>> ---
>> arch/x86/include/asm/apic.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
>> index 1243577..71c1fe2 100644
>> --- a/arch/x86/include/asm/apic.h
>> +++ b/arch/x86/include/asm/apic.h
>> @@ -650,8 +650,8 @@ static inline void entering_ack_irq(void)
>>
>> static inline void ipi_entering_ack_irq(void)
>> {
>> - ack_APIC_irq();
>> irq_enter();
>> + ack_APIC_irq();
>> }
>
> which makes ipi_entering_ack_irq() the same as entering_ack_irq() and
> therefor pointless.

They are still similar before this fix.
https://lkml.org/lkml/2016/3/18/332 I just sent out v2 for both
ipi_entering_ack_irq() and exiting_ack_irq().

Regards,
Wanpeng Li

\
 
 \ /
  Last update: 2016-09-18 13:36    [W:0.087 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site