Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 18 Sep 2016 11:15:22 -0700 | Subject | Re: [GIT pull] irq fixes for 4.8 |
| |
On Sun, Sep 18, 2016 at 1:05 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > > Boris Brezillon (2): > genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers
This seems somewhat questionable.
The non-irqsafe versions of these functions have specialized non-SMP versions for them. The new ones don't.
I pulled it, because I think it's actually the old versions that are garbage (the locking should become a no-op on UP regardless - except for the preemption issue which I don't see why it wouldn't be real), but I think this is inconsistent and should be fixed (or a comment added about why it is ok).
Linus
| |