lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/3] usb: dwc2: cleanup with list_first_entry_or_null()
    Date
    The combo of list_empty() check and return list_first_entry()
    can be replaced with list_first_entry_or_null().

    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    Acked-by: John Youn <johnyoun@synopsys.com>
    ---

    drivers/usb/dwc2/gadget.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
    index af46adf..28a250a 100644
    --- a/drivers/usb/dwc2/gadget.c
    +++ b/drivers/usb/dwc2/gadget.c
    @@ -1098,10 +1098,8 @@ static int dwc2_hsotg_ep_sethalt(struct usb_ep *ep, int value, bool now);
    */
    static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
    {
    - if (list_empty(&hs_ep->queue))
    - return NULL;
    -
    - return list_first_entry(&hs_ep->queue, struct dwc2_hsotg_req, queue);
    + return list_first_entry_or_null(&hs_ep->queue, struct dwc2_hsotg_req,
    + queue);
    }

    /**
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-09-18 18:04    [W:2.726 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site