lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/6] firmware-qemu_fw_cfg: Rename jump labels in fw_cfg_register_file()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 18 Sep 2016 11:23:46 +0200

    Adjust jump labels according to the current Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/firmware/qemu_fw_cfg.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
    index a229df6..a834d01 100644
    --- a/drivers/firmware/qemu_fw_cfg.c
    +++ b/drivers/firmware/qemu_fw_cfg.c
    @@ -464,12 +464,12 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
    err = kobject_init_and_add(&entry->kobj, &fw_cfg_sysfs_entry_ktype,
    fw_cfg_sel_ko, "%d", entry->f.select);
    if (err)
    - goto err_register;
    + goto free_entry;

    /* add raw binary content access */
    err = sysfs_create_bin_file(&entry->kobj, &fw_cfg_sysfs_attr_raw);
    if (err)
    - goto err_add_raw;
    + goto delete_object;

    /* try adding "/sys/firmware/qemu_fw_cfg/by_name/" symlink */
    fw_cfg_build_symlink(fw_cfg_fname_kset, &entry->kobj, entry->f.name);
    @@ -477,10 +477,9 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
    /* success, add entry to global cache */
    fw_cfg_sysfs_cache_enlist(entry);
    return 0;
    -
    -err_add_raw:
    + delete_object:
    kobject_del(&entry->kobj);
    -err_register:
    + free_entry:
    kfree(entry);
    return err;
    }
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-18 14:55    [W:4.053 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site