Messages in this thread | | | Subject | Re: [PATCH v3 1/3] nvme/scsi: Remove power management support | From | J Freyensee <> | Date | Fri, 16 Sep 2016 16:33:11 -0700 |
| |
On Fri, 2016-09-16 at 10:33 +0200, Christoph Hellwig wrote: > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote: > > > > As far as I can tell, there is basically nothing correct about this > > code. It misinterprets npss (off-by-one). It hardcodes a bunch of > > power states, which is nonsense, because they're all just indices > > into a table that software needs to parse. It completely ignores > > the distinction between operational and non-operational states. > > And, until 4.8, if all of the above magically succeeded, it would > > dereference a NULL pointer and OOPS. > > > > Since this code appears to be useless, just delete it. > > Yes, please! > > Acked-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
| |