Messages in this thread | | | Subject | Re: [PATCH v3] leds: Introduce userspace leds driver | From | David Lechner <> | Date | Fri, 16 Sep 2016 10:41:20 -0500 |
| |
On 09/16/2016 01:07 AM, Pavel Machek wrote: > Hi! > > +static ssize_t uleds_read(struct file *file, char __user *buffer, > size_t count, > + loff_t *ppos) > +{ > + struct uleds_device *udev = file->private_data; > + ssize_t retval; > + > + if (count == 0) > + return 0; > + > + if (count != 1) > + return -EINVAL; > > This is quite anti-social. You are free to return 1 byte on any read > (short read), but please allow reads with bigger buffers. > > Thanks, > Pavel >
Sure.
| |