Messages in this thread | | | Subject | Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings | From | zerons <> | Date | Fri, 16 Sep 2016 21:54:36 +0800 |
| |
On 09/16/2016 08:57 PM, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Fri, Sep 16, 2016 at 06:41:38PM +0800, zerons wrote: >> these marcos are used to get the value or address of a member of a `__iomem` structure. >> GET_FIELDADDR is like &iomem_obj->field, and >> GET_FIELD32 is iomem_obj->u32val, GET_FIELD64 is iomem_obj->u64val. >> >> If patch the .c file directly, the source gets into a mess. > > But add the macro, and then use it, in the same patch, so we can verify > that this macro really is doing what you think it is doing, and so that > it is used at the same time (no need to add a macro that no one uses... > > thanks, > > greg k-h >
Again, sorry about the `top-posting`. I am still not familiar with these things, thanks for reminding me, I will follow the rules and try my best not to waste your time.
Ok, I will add the macro and use it to fix the warning in the same patch, and resend the patches.
| |