lkml.org 
[lkml]   [2016]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal_khz whitelist


On 09/15/2016 01:43 PM, Peter Zijlstra wrote:
> On Thu, Sep 15, 2016 at 04:08:36PM +0000, Brown, Len wrote:
>>> + crystal_khz = 24000; /* 25.0 MHz */
>>
>> I guess I prefer no comment over an incorrect comment.
>>
>
> From this I take it it should really have been 24 MHz and it could have
> joined the existing case. I assumed (ha!) that since it had a special
> separate case the comment was correct.

AFAICT, it should be 25000. Len -- can you explicitly confirm that? The
turbostat code contains (tools/power/x86/turbostat/turbostat.c:3312)

case 0x55: /* SKX */
crystal_hz = 25000000; /* 25.0 MHz */


P.

>

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.462 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site