lkml.org 
[lkml]   [2016]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD
Date


> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: Wednesday, September 14, 2016 9:27 PM
> To: J . German Rivera <German.Rivera@freescale.com>; Stuart Yoder <stuart.yoder@nxp.com>; Greg Kroah-
> Hartman <gregkh@linuxfoundation.org>; German Rivera <german.rivera@nxp.com>; Itai Katz
> <itai.katz@nxp.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org
> Subject: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-
> allocator.c
> index 2004fa7..1e06d28 100644
> --- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> @@ -142,8 +142,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device
> goto out_unlock;
> }
>
> - list_del(&resource->node);
> - INIT_LIST_HEAD(&resource->node);
> + list_del_init(&resource->node);
> res_pool->free_count--;
> res_pool->max_count--;
>
> @@ -220,8 +219,7 @@ int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
> res_pool->free_count > res_pool->max_count))
> goto out_unlock;
>
> - list_del(&resource->node);
> - INIT_LIST_HEAD(&resource->node);
> + list_del_init(&resource->node);
>
> res_pool->free_count--;
> error = 0;

Acked-by: Stuart Yoder <stuart.yoder@nxp.com>

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.050 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site