Messages in this thread | | | Date | Thu, 15 Sep 2016 15:35:58 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3] leds: Introduce userspace leds driver |
| |
Hi!
> > >+ if (copy_from_user(&udev->user_dev, buffer, > > >+ sizeof(struct uleds_user_dev))) { > > >+ ret = -EFAULT; > > >+ goto out; > > >+ } > > >+ > > >+ if (!udev->user_dev.name[0]) { > > >+ ret = -EINVAL; > > >+ goto out; > > >+ } > > >+ > > >+ ret = led_classdev_register(NULL, &udev->led_cdev); > > >+ if (ret < 0) > > >+ goto out; > > No sanity checking on the name -> probably a security hole. Do not > push this upstream before this is fixed.
And actually... is it possible to have more then one userspace LED with this interface? I do have RGB LED connect on /dev/ttyUSB0, and I guess userspace driver would be appropriate, but it needs 3 channels...
Best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |