lkml.org 
[lkml]   [2016]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] leds: Introduce userspace leds driver
Hi!

> > >+ if (copy_from_user(&udev->user_dev, buffer,
> > >+ sizeof(struct uleds_user_dev))) {
> > >+ ret = -EFAULT;
> > >+ goto out;
> > >+ }
> > >+
> > >+ if (!udev->user_dev.name[0]) {
> > >+ ret = -EINVAL;
> > >+ goto out;
> > >+ }
> > >+
> > >+ ret = led_classdev_register(NULL, &udev->led_cdev);
> > >+ if (ret < 0)
> > >+ goto out;
>
> No sanity checking on the name -> probably a security hole. Do not
> push this upstream before this is fixed.

And actually... is it possible to have more then one userspace LED
with this interface? I do have RGB LED connect on /dev/ttyUSB0, and I
guess userspace driver would be appropriate, but it needs 3
channels...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.153 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site