lkml.org 
[lkml]   [2016]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/6] leds: gpio: fix an unhandled error case in create_gpio_led
From
Date
Hi Heiner,

On 09/13/2016 08:53 PM, Heiner Kallweit wrote:
> gpiod_get_value_cansleep returns 0, 1, or an error code.
> So far errors are not handled and treated the same as 1.
> Change this to bail out if an error code is returned and
> remove the double negation.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/leds/leds-gpio.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 3599b2e..10c851e 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -118,10 +118,13 @@ static int create_gpio_led(const struct gpio_led *template,
> led_dat->platform_gpio_blink_set = blink_set;
> led_dat->cdev.blink_set = gpio_blink_set;
> }
> - if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP)
> - state = !!gpiod_get_value_cansleep(led_dat->gpiod);
> - else
> + if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) {
> + state = gpiod_get_value_cansleep(led_dat->gpiod);
> + if (state < 0)
> + return state;
> + } else {
> state = (template->default_state == LEDS_GPIO_DEFSTATE_ON);
> + }
> led_dat->cdev.brightness = state ? LED_FULL : LED_OFF;
> if (!template->retain_state_suspended)
> led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;
>

Thanks for the updated patch set. Applied.

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.062 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site