lkml.org 
[lkml]   [2016]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period
On Wed, Sep 14, 2016 at 11:03:18PM +0300, Grygorii Strashko wrote:
> On 09/14/2016 05:25 PM, Richard Cochran wrote:
> > On Wed, Sep 14, 2016 at 04:02:30PM +0300, Grygorii Strashko wrote:
> >> @@ -427,9 +427,6 @@ static void cpts_calc_mult_shift(struct cpts *cpts)
> >> u64 ns;
> >> u64 frac;
> >>
> >> - if (cpts->cc_mult || cpts->cc.shift)
> >> - return;
> >> -
> >> freq = clk_get_rate(cpts->refclk);
> >>
> >> /* Calc the maximum number of seconds which we can run before
> >
> > This hunk has nothing to do with $subject.
>
> Sry, but I did not get your comment here :(
> I'd happy to update patch according to your request, but could you provide more info here, pls?

You added that code in patch #7. Then you moved it in patch #8. You
could have made the code correct in patch #7 to begin with.

> >> cpts->cc_mult = mult;
> >> cpts->cc.mult = mult;
> >> cpts->cc.shift = shift;
> >> +

If you want a blank line here, then put into the original patch #7.

Thanks,
Richard

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.128 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site