lkml.org 
[lkml]   [2016]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 40/51] usb: phy: add USB_SUPPORT dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
    USB core layer, and it fails to build when that is not provided:

    drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
    phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy'

    We already have a couple of other PHY drivers with a dependency
    on USB_SUPPORT, so that seems to be the easiest fix here.

    An alternative would be to adjust the #ifdef in include/linux/usb/of.h
    to also check for CONFIG_USB_SUPPORT.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    ---
    drivers/phy/Kconfig | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
    index 1f3e1fb..fe00f91 100644
    --- a/drivers/phy/Kconfig
    +++ b/drivers/phy/Kconfig
    @@ -267,7 +267,9 @@ config PHY_SUN4I_USB
    depends on RESET_CONTROLLER
    depends on EXTCON
    depends on POWER_SUPPLY
    + depends on USB_SUPPORT
    select GENERIC_PHY
    + select USB_COMMON
    help
    Enable this to support the transceiver that is part of Allwinner
    sunxi SoCs.
    --
    1.7.9.5
    \
     
     \ /
      Last update: 2016-09-17 09:59    [W:4.070 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site