lkml.org 
[lkml]   [2016]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
* Bin Liu <b-liu@ti.com> [160908 11:26]:
> On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > config USB_MUSB_TUSB6010
> > tristate "TUSB6010"
> > depends on HAS_IOMEM
> > - depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
>
> Would this cause more issue later when trying to enable all glue drivers
> in one build?

Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
It completely redefines all the registers with ifdef else.

> The macros defined in tusb6010.h are only used in tusb6010.c, so how
> about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> instead? This gives flexibility to random config test, isn't it?

I'd like to see that but we have this in musb_core.c:

hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;

So the build would break there again on blackin with tusb6010..
Got any ideas on how to sort that out?

Regards,

Tony

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.074 / U:2.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site