lkml.org 
[lkml]   [2016]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 4/7] AGPGART-SGI: Use kmalloc_array() in agp_sgi_init()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 13 Sep 2016 21:30:58 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/char/agp/sgi-agp.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/char/agp/sgi-agp.c b/drivers/char/agp/sgi-agp.c
    index 3051c73..798ad20 100644
    --- a/drivers/char/agp/sgi-agp.c
    +++ b/drivers/char/agp/sgi-agp.c
    @@ -280,9 +280,9 @@ static int agp_sgi_init(void)
    else
    return 0;

    - sgi_tioca_agp_bridges = kmalloc(tioca_gart_found *
    - sizeof(struct agp_bridge_data *),
    - GFP_KERNEL);
    + sgi_tioca_agp_bridges = kmalloc_array(tioca_gart_found,
    + sizeof(*sgi_tioca_agp_bridges),
    + GFP_KERNEL);
    if (!sgi_tioca_agp_bridges)
    return -ENOMEM;

    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-17 09:59    [W:5.852 / U:1.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site