Messages in this thread | | | Date | Tue, 13 Sep 2016 15:38:14 +0200 | From | LABBE Corentin <> | Subject | Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module |
| |
On Mon, Sep 12, 2016 at 09:28:12AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in this syscon and the only one useful is > > the one dedicated to EMAC clock. > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index fdf9fdb..a39da6f 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -140,6 +140,11 @@ > > #size-cells = <1>; > > ranges; > > > > + syscon: syscon@01c00000 { > > + compatible = "syscon"; > > Having our compatible would be nice here. syscon doesn't mean anything > by itself. >
Since no driver handle it, I follow what I saw in other DT. At your choice, I can add a sun8i-syscon, but it will be unused.
> > + reg = <0x01c00000 0x34>; > > And the size of our system controller is 0x1000 >
I put the real size used, but I can put what datasheet said.
Regards
Corentin Labbe
| |