Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 13 Sep 2016 10:42:50 +0200 | Subject | Re: [PATCH] pinctrl: aspeed: fix regmap error handling |
| |
On Fri, Sep 9, 2016 at 11:26 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added aspeed driver tries to check for a negative return > value from a pinctrl function, but stores the intermediate value in > a 'bool' variable, which cannot work: > > drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function 'aspeed_sig_expr_set': > drivers/pinctrl/aspeed/pinctrl-aspeed.c:192:11: error: comparison of constant '0' with boolean expression is always false [-Werror=bool-compare] > > This slightly reworks the logic to use an explicit comparison with zero > before assigning to the temporary variable. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied with the ACKs. Also added Colin as Reported-by.
Yours, Linus Walleij
| |