lkml.org 
[lkml]   [2016]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting
From
Date
Hello.

On 9/12/2016 12:29 PM, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/atm/iphase.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
> if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
> return ret;
> }
> - }
> - else
> - printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
> + } else
> + printk("iadev: Non UBR, ABR and CBR traffic not supported\n");

All branches of the *if* statement should have {} if at least one has them
(perhaps a material for a follow-up patch).

[...]

MBR, Sergei

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:1.447 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site