| Subject | Re: [PATCH 23/26] sh_eth: constify local structures | From | Sergei Shtylyov <> | Date | Sun, 11 Sep 2016 21:14:13 +0300 |
| |
On 09/11/2016 04:06 PM, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned.
Really?
> 2. Address never taken
Really?
> 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches <joe@perches.com>. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
NAK, see sh_eth_set_default_cpu_data().
MBR, Sergei
|