Messages in this thread Patch in this message | | | Subject | [PATCH 1/7] cfag12864b: Use kmalloc_array() in cfag12864b_init() | From | SF Markus Elfring <> | Date | Sat, 10 Sep 2016 16:23:57 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 10 Sep 2016 14:40:48 +0200
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/auxdisplay/cfag12864b.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index 41ce4bd..88260f4 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -347,8 +347,9 @@ static int __init cfag12864b_init(void) goto none; } - cfag12864b_cache = kmalloc(sizeof(unsigned char) * - CFAG12864B_SIZE, GFP_KERNEL); + cfag12864b_cache = kmalloc_array(CFAG12864B_SIZE, + sizeof(*cfag12864b_cache), + GFP_KERNEL); if (cfag12864b_cache == NULL) { printk(KERN_ERR CFAG12864B_NAME ": ERROR: " "can't alloc cache buffer (%i bytes)\n", -- 2.10.0
| |