lkml.org 
[lkml]   [2016]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ASoC: davinci-mcasp: off-by-one in 'davinci_mcasp_hw_rule_format'
    Date
    When calling 'snd_pcm_format_width', SNDRV_PCM_FORMAT_LAST is a
    valid value, so don't skip it.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    Un-tested
    ---
    sound/soc/davinci/davinci-mcasp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
    index 05c2d33aa74d..3c5a9804d3f5 100644
    --- a/sound/soc/davinci/davinci-mcasp.c
    +++ b/sound/soc/davinci/davinci-mcasp.c
    @@ -1218,7 +1218,7 @@ static int davinci_mcasp_hw_rule_format(struct snd_pcm_hw_params *params,

    snd_mask_none(&nfmt);

    - for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
    + for (i = 0; i <= SNDRV_PCM_FORMAT_LAST; i++) {
    if (snd_mask_test(fmt, i)) {
    uint sbits = snd_pcm_format_width(i);
    int ppm;
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.144 / U:1.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site